[ENG-9542] specify needed columns to extract for registation/preprint/project csv tsv downloading for /institutions/cos/dashboard/ #720
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…v tsv downloading for /institutions/cos/dashboard/
… don't contain the user guid (labeled OSF Link in the table))
nsemets
requested changes
Oct 27, 2025
| 'usage.viewCount', | ||
| 'usage.downloadCount', | ||
| ]; | ||
| const resourceType = 'Preprint'; |
Comment on lines
108
to
118
| const fields = [ | ||
| 'title', | ||
| 'dateCreated', | ||
| 'dateModified', | ||
| 'sameAs', | ||
| 'rights.name', | ||
| 'creator.@id', | ||
| 'creator.name', | ||
| 'usage.viewCount', | ||
| 'usage.downloadCount', | ||
| ]; |
There was a problem hiding this comment.
You can move it to the download-url.helper.ts file, and use the appropriate fields there based on the type. It would also be better to move the related constants to a separate constants file. Update it for all files.
|
@mkovalua Fix lint issues. |
nsemets
approved these changes
Oct 29, 2025
nsemets
merged commit 4bf70b8
into
CenterForOpenScience:feature/pbs-25.02
3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Return proper columns for registation/preprint/project csv tsv for institutions tab
Summary of Changes
specify needed columns to extract for registation/preprint/project csv tsv downloading for /institutions/cos/dashboard/
Screenshot(s)
Side Effects
QA Notes